Pauser and renounceAdmin Drips tests

ScopeLift / radworks-governor-upgrade

0 stars 0 forks source link

Pauser and renounceAdmin Drips tests #18

Closed jferas closed 8 months ago

jferas commented 9 months ago

This PR contains test for testing manipulation (via governance) of the "pauser" and "renounceAdmin" related functions of the Drips protocol. Additional PR(s) will test the ability (via governance) to change the "admin" of the Drips protocol.

jferas commented 9 months ago

Current dependencies on/for this PR:

main
- PR #1
- PR #2
  - PR #5
  - PR #8
    - PR #12
    - PR #15
    - PR #14
      - PR #19
      - PR #18 👈
      - PR #21
        
        PR #22
    - PR #13

This stack of pull requests is managed by Graphite.

jferas commented 9 months ago

looks good, mostly nits.

just double checking, is the granting/revoking of pauser (and then the admin renouncement) the only functionality we need to test? if so, looks great.

There is a separate PR for testing the changing of admin as well as upgrade of the Drips protocol

jferas commented 9 months ago

Added a commit that adds .DS_Store to .gitignore file for smoother MacOS git operations https://github.com/ScopeLift/radworks-governor-upgrade/pull/18/commits/bf585a14b4137012761daa82892af10a402534c4

github-actions[bot] commented 9 months ago

Coverage after merging drips-tests into main will be

76.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
RadworksGovernor.sol	73.91%	75%	69.23%	76%	101, 126–127, 135, 138, 152, 203, 84