ScopeLift / radworks-governor-upgrade

0 stars 0 forks source link

Cleanup test names / scopelint fix #22

Closed jferas closed 8 months ago

jferas commented 9 months ago

Cleaned up test contracts and how they are organized and named for better compatibility with "scopelint spec" command.

jferas commented 9 months ago

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

jferas commented 9 months ago

This commit https://github.com/ScopeLift/radworks-governor-upgrade/pull/22/commits/e41b46345e0c07f0c7d72106b77953d15889e454 moved test functions from RadworksGovernorAlpha.t.sol (and deleted it) into RadworksGovernor.t.sol so that the test functions would be reported on by scopelint spec which expects the tests to reside in a test file with the same base name as the contract to be tested.

github-actions[bot] commented 8 months ago

Coverage after merging test-cleanup-scopelint-spec-fix into main will be

76.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   RadworksGovernor.sol73.91%75%69.23%76%101, 126–127, 135, 138, 152, 203, 84