Currently, a number of the ReimbursementPool contract tests pay half the debt before making assertions. This can sometimes lead to tests passing that shouldn't. A common case this happens is something like:
Quantity of tokens is 100
We want to subtract x% from quantity, so new quantity is 100 * (1 - x)
If we subtract 50% in our test, quantity = 100 * (1 - 0.5) = 50
If we forgot the 1 - portion of the code, you still get 50 as the right answer, even though the code is wrong
If we forgot the 1 - portion and tested with 25%, then we'd get a wrong answer making it clear the code is wrong
Rework the test suite to avoid using halves but still exercising all the functionality.
Currently, a number of the ReimbursementPool contract tests pay half the debt before making assertions. This can sometimes lead to tests passing that shouldn't. A common case this happens is something like:
Rework the test suite to avoid using halves but still exercising all the functionality.