Uni v3 price oracle - Githubissues

ScopeLift / reimbursement-tokens

0 stars 0 forks source link

Uni v3 price oracle #36

Closed wildmolasses closed 2 years ago

wildmolasses commented 2 years ago

Resolves #20

Some leftover considerations:

instead of taking a baseAmount in oracle impl constructor, I think it might be more appropriate to hardcode it to 1 * 10^tokenDecimals
shall we do a small refactor of riToken and riPool tests to rely more on helper imports (i.e. refactor helper methods to utils.ts, and use deployTokens method from setup.ts)
does documentation of oracle considerations belong in this PR or can it come when addressing #12