ScopeLift / umbra-protocol

🌕🌑 Privacy Preserving Shielded Payments On The Ethereum Blockchain
https://app.umbra.cash
MIT License
356 stars 91 forks source link

Remove potential ENS lookup error message overlap on batch sends. #649

Closed jferas closed 6 months ago

jferas commented 7 months ago

Resolves #646

Remove offending Recipient ID string from error message for more consistent layout.

Because the existing ENS lookup error message contains the variable length Recipient ID, when it is long is can cause the error message to sometime pop down over either the confusables warning message or the next batch send label. The variable length of the error string popped down by the base-input component makes layout calculations problematic. Made the change to substitute a fixed length error message here in the frontend rather than in UmbraJS to ensure users of UmbraJS aren't affected by any messaging changes the thrown error.

Dependance on a specific string from UmbraJS is somewhat brittle, if there's a better way to accomplish, please mention in review.

netlify[bot] commented 7 months ago

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
Latest commit ddec7ae5870a93adc445e652b57f543eb3df9b38
Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/65ea0fcd326be900088f7ce6
Deploy Preview https://deploy-preview-649--jolly-shaw-20fe62.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 6 months ago

Coverage after merging fix-error-overlap into master will be

81.15%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol100%100%100%100%
   UniswapWithdrawHook.sol100%100%100%100%
umbra-js/src
   ethers.ts76.27%100%61.11%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts77.55%76.47%66.67%79.31%11, 11, 19–20, 31, 38, 44, 53, 57, 8
   Umbra.ts75.21%63.01%82.93%81.95%103, 132–133, 154, 226–228, 312–315, 377, 391, 398–400, 402–403, 406–407, 425, 427, 429, 429, 429, 429–430, 430, 430–432, 447, 447, 447–448, 452, 455, 475, 493–494, 581, 598, 611–612, 622–623, 636, 639–640, 670–671, 747, 751, 751, 751–754, 754, 754, 754, 754, 754, 754–755, 755, 755, 755, 755, 755, 755, 755, 755, 755, 755, 757, 757, 757–758, 761, 761, 761, 761, 761–762, 765, 774, 774, 783, 786, 786, 786–788, 801, 805, 808–809, 815–817, 824, 824, 824–827, 858, 863–864, 864–865
umbra-js/src/typechain
   index.ts70.59%100%37.50%100%
umbra-js/src/typechain/factories
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/access
   Ownable__factory.ts50%100%0%66.67%70, 76
   index.ts50%100%0%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/token
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/token/ERC20
   ERC20__factory.ts29.03%0%12.50%47.06%310, 314, 314, 314–315, 317, 326, 326, 326, 333, 333, 333, 336, 339, 345
   IERC20__factory.ts50%100%0%66.67%201, 204
   index.ts50%100%0%100%
umbra-js/src/typechain/factories/contracts
   IUmbraHookReceiver__factory.ts50%100%0%66.67%61, 67
   MockHook__factory.ts22.58%0%0%41.18%107, 111, 111, 111–112, 114, 121, 121, 121, 126, 126, 126, 129, 132, 138, 144
   StealthKeyRegistry__factory.ts22.58%0%0%41.18%202, 206, 206, 206–207, 209, 216, 216, 216, 221, 221, 221, 224, 227, 233, 239
   TestToken__factory.ts64.52%66.67%50%70.59%329–330, 348, 351, 354, 360, 366
   Umbra__factory.ts70.97%66.67%62.50%76.47%495–496, 525, 529, 532, 538
   index.ts50%100%0%100%
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts76.67%68.66%76.92%82%109–111, 113–115, 121, 139–140, 169, 190, 246, 253–260, 260, 260, 260, 260, 260, 260–261, 263, 294, 296–297, 306, 306, 306–307, 309, 312, 321–322, 363, 380, 380, 380, 400, 429, 431, 436, 448, 448–449, 454, 456–457, 468–472, 478, 480, 522–523, 523, 523–525, 525, 525, 536, 59–60, 779–780, 792–793, 85, 93, 93
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%