search

ScoreSaber / scoresaber-frontend

MIT License
87 stars 16 forks source link

feat: adding basic stats to mobile ranking #50

Closed motzel closed 2 years ago

motzel commented 2 years ago

image

wolfcomp commented 2 years ago

Check if this messes up the country rank implementation size of the top row.

motzel commented 2 years ago

I checked it out before I made the PR

image

Umbranoxio commented 2 years ago

I'm not sure why we need this when we have this? image In my opinion it makes the page look rather clunky

motzel commented 2 years ago

Well, for the very same reason it's displayed in the desktop version. The ranking is based on PPs and it is important to see at glance if the difference between players is 5pp or 500pp. Without constantly clicking on individual players and going back to the ranking.

Umbranoxio commented 2 years ago

While I can agree with the sentiment of having things available at a glance, to the average person I feel the UX would be rather confusing, a lot of unexplained data.

motzel commented 2 years ago

I think the data explains itself with their suffixes. Any person who uses SS knows what PP or % is. Also under this assumption the scores are confusing as well.

image

Same data, no explanation.

IMO, the current implementation looks like there is a bug - no data, and on top of that third the screen, so valuable on mobile, is blank.

image