search

Scorr / RetroUnity

Unity frontend for the libretro API.
GNU General Public License v3.0
41 stars 23 forks source link

Added Sega Genesis support by fixing LibretroWraper.cs switch case XR… #12

Open cph5236 opened 4 years ago

cph5236 commented 4 years ago

…GB8888 it now uses RGB8888 jobs in unities jobs system, fixed RetroAudioSample function.

cph5236 commented 4 years ago

Hey Scorr are you going to approve this request?

supneo commented 4 years ago

Hello, interesting, thanks for the contribution.

Hokage3211 commented 4 years ago

Hey there! Trying to replicate these changes, it didn't work on the plusGX core (getting editor-level crashes), but it does seem to make the blastem core work, however there is large audio crackling as well as the main problem which is the screen being shifted like wrapped a million times the wrong way, in stripes. Did I miss a change or something? I'm mostly hand-reading each line to pull changes, since I already made conflicting changes so I can't just pull merge.

cph5236 commented 4 years ago

I had the screen warping and audio crackeling fixed on my end with the blastem core. Maybe try another rom for now I can look into this later.

On Sat, Sep 5, 2020, 11:14 PM Hokage3211 notifications@github.com wrote:

Hey there! Trying to replicate these changes, it didn't work on the plusGX core (getting editor-level crashes), but it does seem to make the blastem core work, however there is large audio crackling as well as the main problem which is the screen being shifted like wrapped a million times the wrong way, in stripes. Did I miss a change or something? I'm mostly hand-reading each line to pull changes, since I already made conflicting changes so I can't just pull merge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Scorr/RetroUnity/pull/12#issuecomment-687692782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH5EH2Z5ECASI4JM6ZGQPQLSEL5BTANCNFSM4KAA7HTQ .

Hokage3211 commented 4 years ago

Perhaps there is a missing change in code not commited on your end? I was testing with a sonic the hedgehog 2, what did you use to test? Or if it helps, do you remember what lines of code fixed the warping, and I can see if I have them correct?

cph5236 commented 4 years ago

I tested with multiple different games like jurassic Park and sonic

On Sun, Sep 6, 2020, 5:21 PM Hokage3211 notifications@github.com wrote:

Perhaps there is a missing change in code not commited on your end? I was testing with a sonic the hedgehog 2, what did you use to test?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Scorr/RetroUnity/pull/12#issuecomment-687904918, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH5EH24DXSK5B3VDWHEYJSLSEP4NZANCNFSM4KAA7HTQ .

Scorr commented 4 years ago

Hey sorry for the late reply, haven't looked at this repo in a while. I've been wanting to rework it but haven't had time.

Just tested your PR, screen is also warped with stripes for me using blastem. Is there a configuration with which this works that I could test (Game + libretro core)? The audio crackle is not a problem since that was already an issue before this PR.