search

Scorr / RetroUnity

Unity frontend for the libretro API.
GNU General Public License v3.0
41 stars 23 forks source link

Linux/MacOS/Android support + Stereo sound #16

Closed humbertodias closed 4 years ago

humbertodias commented 4 years ago

libretro

Hokage3211 commented 4 years ago

It seems like 80% of the changes here are just formatting, which makes it a lot harder to see what is and isn't supposed to actually change.

humbertodias commented 4 years ago

APK - https://drive.google.com/drive/folders/1WHzqBRqeHqVlM4XHUJNfonVlScWjnDNo?usp=sharing Cores libretro - http://buildbot.libretro.com/nightly/android/latest/armeabi-v7a/ Classic Kong - https://github.com/nathancassano/classickong

retrounity-android retrounity-libretro

Tool that download libretro cores automatically libretro-download-cores

Scorr commented 4 years ago

Seems like a lot of changes that aren't specific to the issue, such as formatting, including code from the other current PRs and including rom/core in the project. I think you did good work, but it seems like too many changes for me to merge into the main repo.

It looks like the platform specific DLL handlers are the main thing needed for multiplat support, so if that's the case, if you made a seperate PR or did a rebase with only the DLL handlers I'd likely merge that.

The tool to download cores automatically seems like a great idea. If you want to make a new PR with just CoreDownloader.cs, I'd also be happy to merge that :+1: