ScotGovAnalysis / opendatascot

An R package to pull data from statistics.gov.scot into R

https://scotgovanalysis.github.io/opendatascot/

MIT License

47 stars 6 forks source link

#11 handle errors #67

Closed thomascrines closed 5 years ago

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~

codecov-io commented 5 years ago

Codecov Report

Merging #67 into master will decrease coverage by 8.41%. The diff coverage is 72.58%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   86.54%   78.13%   -8.42%     
==========================================
  Files           7        8       +1     
  Lines         171      215      +44     
==========================================
+ Hits          148      168      +20     
- Misses         23       47      +24

Impacted Files	Coverage Δ
R/ods_dataset.R	`76.31% <70%> (+18.62%)`	:arrow_up:
R/ods_error_message.R	`75% <75%> (ø)`
R/ods_print_query.R	`65.11% <0%> (-20.94%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21aa8b6...bc481aa. Read the comment docs.

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~

lintr-bot commented 5 years ago

tests/testthat/test_ods_error_message.R:20:5: style: Commented code should be removed.

#   skip_on_cran()
    ^~~~~~~~~~~~~~