search

Scotsguy / now-playing

Minecraft mod that shows a 'now playing' popup whenever music changes.
MIT License
11 stars 5 forks source link

Now Playing toast does not show when music is not in the "minecraft" namespace #10

Closed SusStew closed 2 years ago

SusStew commented 3 years ago

In this resource pack, the music will play but will not show the name of the song. The music is in the "bgm" namespace.

In this resource pack, the music will play but will not show the name of the song. The music is in the "minecraft" namespace.

This would probably also affect content mods which add music.

SusStew commented 3 years ago

This is on the fabric version of the mod.

JayJay1989 commented 3 years ago

To be able to show the the current track of those packs, you need to add it in the language. like this: language file

SusStew commented 3 years ago

To be able to show the the current track of those packs, you need to add it in the language. like this: language file

That only works when it's set to minecraft:music/path/to/file. When it is set to any namespace other than minecraft, e.g. bgm:music/path/to/file, it doesn't work.

JayJay1989 commented 3 years ago

hmm, i will fix this when i have some spare time

Scotsguy commented 2 years ago

This works now, and will be in the v1.4.0 release of the mod. I'll see about releasing that soon.

image