Scotsguy / now-playing

Minecraft mod that shows a 'now playing' popup whenever music changes.
MIT License
10 stars 4 forks source link

[Feature request] Change toast notification width based on song name length #7

Closed cs127 closed 2 years ago

cs127 commented 3 years ago

A lot of custom songs in my resource pack have long names and I would like this mod to show wider notifications to have the entire text visible. I don't actually know if resizing the toasts is easily possible to do though. If it is possible, I would really appreciate it if you added this feature! Also I use Fabric.

Scotsguy commented 3 years ago

Sounds reasonably doable, would just need to repeat the middle part of the texture until the name fits. Do you have a resource pack I could test this with?

cs127 commented 3 years ago

Sorry for the late response! I've been busy and I forgot about this! Here's a test resource pack that I made right now, it replaces the music.game sound event with only two of the Minecraft songs, and I added a custom name for both of them in the assets/now_playing/lang/en_us.json language file.

Here's the resource pack.

This is how it looks in the game: screenshot

Scotsguy commented 2 years ago

Fixed in v1.4.0, sorry for the delay.

cs127 commented 2 years ago

thanks!