search

Scotsguy / now-playing

Minecraft mod that shows a 'now playing' popup whenever music changes.
MIT License
11 stars 5 forks source link

Add Song Names for Dynamic Music's tracks #9

Closed Just-Leah closed 2 years ago

Just-Leah commented 3 years ago

I have this mod with the mod Dynamic Music and the toasts from this mod do not always appear with the other mod. Expected behavior The toasts appear for the tracks played. Actual result The toasts do not appear for some songs.

For extra context, I also have Music Duration Reducer installed, but the issue happened before I added it

Just-Leah commented 3 years ago

For extra context, I’m on fabric Sorry for not clarifying that earlier, I forgot that MDR is for forge as well

Scotsguy commented 2 years ago

Sorry for taking ages to get to this; Dynamic Music adds new songs. These have new names, so to avoid being unhelpful if now playing doesn't know what to call it it'll just not show any toast at all. Maybe I'll add them, but since I only update for the newest version of Minecraft, currently 1.18.2, and Dynamic Music seemingly does not work on that version, it'll have to wait a bit.

Scotsguy commented 2 years ago

Closing, since Dynamic Music still hasn't been updated. I'll take another look when that gets an update.