Cookies named after default properties are not detected

ScottHamper / Cookies

JavaScript Client-Side Cookie Manipulation Library

The Unlicense

1.77k stars 170 forks source link

Closed stash closed 9 years ago

stash commented 9 years ago

Not sure if this is by design, but cookies named after properties of Object.prototype are not placed into the resulting set of cookies.

For example, this means that if one has a cookie named constructor, this cannot be accessed by this library. Other less likely examples are to be found at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/prototype

stash commented 9 years ago

There's a few ways to approach this that come to my mind:

point this out as a limitation in the README and leave it at that
throw an exception when detecting one of these cookies so that it's apparent (perhaps this is unpopular)
somehow allow cookies to be called these reserved names, but don't interfere with the prototype properties (e.g., always prefix the cookies with '.' when storing and doing lookups)

ScottHamper commented 9 years ago

Oh man, this is a really good catch.

I'll fix the issue by prefixing/namespacing keys before caching cookie KVPs, unless something better comes to mind.

Thanks for this! This bug has existed since the initial commit on April 26, 2012. Nuts.