search

ScottHamper / Cookies

JavaScript Client-Side Cookie Manipulation Library
The Unlicense
1.77k stars 170 forks source link

Encoding #55

Closed harshadsheth closed 8 years ago

harshadsheth commented 8 years ago

Hi,

The library ignores the values like $ : while encodingUriComponent for the VALUE to set the cookie. This breaks certain scenarios.

encodeUriComponent takes care of all these things and we should simply call it without the regex. Please fix this or I can PR it.

ScottHamper commented 8 years ago

Hey @geniusXboxer,

The $ character is a valid character for cookie values as specified in RFC6265 (section 4.1.1). As a result, it is not encoded.

Can you describe a reproducible scenario in which having an un-encoded $ causes a problem?

ScottHamper commented 8 years ago

Closing due to months of inactivity.