search

ScottHamper / Cookies

JavaScript Client-Side Cookie Manipulation Library
The Unlicense
1.77k stars 169 forks source link

add samesite support #84

Open mum-never-proud opened 4 years ago

mum-never-proud commented 4 years ago

Resolves #85

koriner commented 4 years ago

@ScottHamper do you have any ETA on when this might get merged? :)

ScottHamper commented 4 years ago

Probably never, to be honest, though it is a well done PR! See #86

koriner commented 4 years ago

@ScottHamper Haha ok fair enough :) The only reason I asked is because this package (https://github.com/abersager/redux-persist-cookie-storage) uses yours as a dependency. Your points in #86 are valid though. We'll either write our own adapter or switch to something else with local storage.