Initial fixes - Githubissues

filcole commented 7 years ago

Onlye one I'm not sure about is the additional VehicleInfoList in leaf.js. Need to compare the json returned for a few Nissan leafs to fully understand... Can we compare?

ScottHelme commented 7 years ago

Happy to compare, I haven't seen that on mine, what vehicle do you have?

filcole commented 7 years ago

Ex-demo Nissan Leaf 30kWh

On 18 December 2016 at 21:25, Scott Helme notifications@github.com wrote:

Happy to compare, I haven't seen that on mine, what vehicle do you have?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ScottHelme/AlexaNissanLeaf/pull/6#issuecomment-267847842, or mute the thread https://github.com/notifications/unsubscribe-auth/AFy_volY_lojXsSrnHW8I807J-HPNHkXks5rJaSvgaJpZM4LQGlG .

-- Phil

ScottHelme commented 7 years ago

Mine is the 24kWh Gen 2, here is my JSON:

array(6) {
  ["status"]=>
  int(200)
  ["vehicleInfo"]=>
  array(1) {
    [0]=>
    array(5) {
      ["vin"]=>
      string(17) "*snip*"
      ["nickname"]=>
      string(4) "Leaf"
      ["charger20066"]=>
      string(5) "false"
      ["telematicsEnabled"]=>
      string(4) "true"
      ["custom_sessionid"]=>
      string(110) "*snip*"
    }
  }
  ["vehicle"]=>
  array(1) {
    ["profile"]=>
    array(8) {
      ["vin"]=>
      string(17) "*snip*"
      ["gdcUserId"]=>
      string(0) ""
      ["gdcPassword"]=>
      string(0) ""
      ["encAuthToken"]=>
      string(64) "*snip*"
      ["dcmId"]=>
      string(12) "*snip*"
      ["status"]=>
      string(4) "true"
      ["statusDate"]=>
      string(17) "*snip*"
      ["nickname"]=>
      string(4) "Leaf"
    }
  }
  ["EncAuthToken"]=>
  string(80) "*snip*"
  ["CustomerInfo"]=>
  array(11) {
    ["UserId"]=>
    string(10) "*snip*"
    ["Language"]=>
    string(5) "en_GB"
    ["Timezone"]=>
    string(12) "Europe/Paris"
    ["RegionCode"]=>
    string(2) "NE"
    ["OwnerId"]=>
    string(10) "*snip*"
    ["EMailAddress"]=>
    string(21) "*snip*"
    ["Nickname"]=>
    string(4) "Leaf"
    ["Country"]=>
    string(2) "GB"
    ["VehicleImage"]=>
    string(47) "/content/language/default/images/img/ph_car.jpg"
    ["UserVehicleBoundDurationSec"]=>
    string(9) "*snip*"
    ["VehicleInfo"]=>
    array(9) {
      ["VIN"]=>
      string(17) "*snip*"
      ["DCMID"]=>
      string(12) "*snip*"
      ["SIMID"]=>
      string(20) "*snip*"
      ["NAVIID"]=>
      string(12) "*snip*"
      ["EncryptedNAVIID"]=>
      string(32) "*snip*"
      ["MSN"]=>
      string(15) "*snip*"
      ["LastVehicleLoginTime"]=>
      string(0) ""
      ["UserVehicleBoundTime"]=>
      string(20) "*snip*"
      ["LastDCMUseTime"]=>
      string(17) "*snip*"
    }
  }
  ["UserInfoRevisionNo"]=>
  string(1) "1"
}

filcole commented 7 years ago

This is me. The vin is identical in all places, it's not that there are two different vins used. So it seams that I get a VehicleInfoList and you don't!

{ "status": 200, "sessionId": "80f03db3-b573-43cf-9678-a67900cbe976", "VehicleInfoList": { "VehicleInfo": [ { "nickname": "Leaf1filc", "telematicsEnabled": "true", "vin": "snip" } ], "vehicleInfo": [ { "nickname": "Leaf1filc", "telematicsEnabled": "true", "vin": "snip", "custom_sessionid": "8l+dYKLHBac/gZ6nqX9sLAblv3K/i4A+8RBQxCCGoQx+ws6I6dj2Aex9Uk/gC8PhbsImJLZ7nE4kwjidsZUBy2wZFKBUTPkWN0eRlUcagruQ==" } ] }, "vehicle": { "profile": { "vin": "snip", "gdcUserId": "", "gdcPassword": "", "encAuthToken": "47D6C6131CF49BAA745DC75BEECD6E9A3675FC72382DF52A0266741F14B92C21", "dcmId": "203560402152", "nickname": "Leaf1filc" } }, "EncAuthToken": "47D6C6131CF49BAA745DC75BEECD6E9A9FF86884042A38C62B6880426B1D931C", "CustomerInfo": { "UserId": "G4W75M64ZYIAWTF1", "Language": "en-GB", "Timezone": "Europe/London", "RegionCode": "NE", "OwnerId": "4063912000", "EMailAddress": "filcole@gmail.com", "Nickname": "Leaf1filc", "Country": "GB", "VehicleImage": "/content/language/default/images/img/ph_car.jpg", "UserVehicleBoundDurationSec": "946771200", "VehicleInfo": { "VIN": "snip", "DCMID": "snip", "SIMID": "snip", "NAVIID": "snip", "EncryptedNAVIID": "snip", "MSN": "snip", "LastVehicleLoginTime": "", "UserVehicleBoundTime": "2016-09-06T12:20:25Z", "LastDCMUseTime": "" } }, "UserInfoRevisionNo": "1" }

On 18 December 2016 at 21:30, Scott Helme notifications@github.com wrote:

Mine is the 24kWh Gen 2, here is my JSON:

array(6) { ["status"]=> int(200) ["vehicleInfo"]=> array(1) { [0]=> array(5) { ["vin"]=> string(17) "snip" ["nickname"]=> string(4) "Leaf" ["charger20066"]=> string(5) "false" ["telematicsEnabled"]=> string(4) "true" ["custom_sessionid"]=> string(110) "snip" } } ["vehicle"]=> array(1) { ["profile"]=> array(8) { ["vin"]=> string(17) "snip" ["gdcUserId"]=> string(0) "" ["gdcPassword"]=> string(0) "" ["encAuthToken"]=> string(64) "snip" ["dcmId"]=> string(12) "snip" ["status"]=> string(4) "true" ["statusDate"]=> string(17) "snip" ["nickname"]=> string(4) "Leaf" } } ["EncAuthToken"]=> string(80) "snip" ["CustomerInfo"]=> array(11) { ["UserId"]=> string(10) "snip" ["Language"]=> string(5) "en_GB" ["Timezone"]=> string(12) "Europe/Paris" ["RegionCode"]=> string(2) "NE" ["OwnerId"]=> string(10) "snip" ["EMailAddress"]=> string(21) "snip" ["Nickname"]=> string(4) "Leaf" ["Country"]=> string(2) "GB" ["VehicleImage"]=> string(47) "/content/language/default/images/img/ph_car.jpg" ["UserVehicleBoundDurationSec"]=> string(9) "snip" ["VehicleInfo"]=> array(9) { ["VIN"]=> string(17) "snip" ["DCMID"]=> string(12) "snip" ["SIMID"]=> string(20) "snip" ["NAVIID"]=> string(12) "snip" ["EncryptedNAVIID"]=> string(32) "snip" ["MSN"]=> string(15) "snip" ["LastVehicleLoginTime"]=> string(0) "" ["UserVehicleBoundTime"]=> string(20) "snip" ["LastDCMUseTime"]=> string(17) "snip" } } ["UserInfoRevisionNo"]=> string(1) "1" }

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ScottHelme/AlexaNissanLeaf/pull/6#issuecomment-267848244, or mute the thread https://github.com/notifications/unsubscribe-auth/AFy_vgJZVku_GO7_FZCIt-vZ78j7CO16ks5rJaYQgaJpZM4LQGlG .

-- Phil

filcole commented 7 years ago

I've updated the pull request to cater for the differences in the responses. Let me know what you think.

On 18 December 2016 at 21:44, Phil Cole filcole@gmail.com wrote:

This is me. The vin is identical in all places, it's not that there are two different vins used. So it seams that I get a VehicleInfoList and you don't!

{ "status": 200, "sessionId": "80f03db3-b573-43cf-9678-a67900cbe976", "VehicleInfoList": { "VehicleInfo": [ { "nickname": "Leaf1filc", "telematicsEnabled": "true", "vin": "snip" } ], "vehicleInfo": [ { "nickname": "Leaf1filc", "telematicsEnabled": "true", "vin": "snip", "custom_sessionid": "8l+dYKLHBac/gZ6nqX9sLAblv3K/i4A+8RBQxCCGoQx+ ws6I6dj2Aex9Uk/gC8PhbsImJLZ7nE4kwjidsZUBy2wZFKBUTPkWN0eRlUcagruQ==" } ] }, "vehicle": { "profile": { "vin": "snip", "gdcUserId": "", "gdcPassword": "", "encAuthToken": "47D6C6131CF49BAA745DC75BEECD6E 9A3675FC72382DF52A0266741F14B92C21", "dcmId": "203560402152", "nickname": "Leaf1filc" } }, "EncAuthToken": "47D6C6131CF49BAA745DC75BEECD6E 9A9FF86884042A38C62B6880426B1D931C", "CustomerInfo": { "UserId": "G4W75M64ZYIAWTF1", "Language": "en-GB", "Timezone": "Europe/London", "RegionCode": "NE", "OwnerId": "4063912000", "EMailAddress": " filcole@gmail.com", "Nickname": "Leaf1filc", "Country": "GB", "VehicleImage": "/content/language/default/images/img/ph_car.jpg", "UserVehicleBoundDurationSec": "946771200", "VehicleInfo": { "VIN": "snip", "DCMID": "snip", "SIMID": "snip", "NAVIID": "snip", "EncryptedNAVIID": "snip", "MSN": "snip", "LastVehicleLoginTime": "", "UserVehicleBoundTime": "2016-09-06T12:20:25Z", "LastDCMUseTime": "" } }, "UserInfoRevisionNo": "1" }

On 18 December 2016 at 21:30, Scott Helme notifications@github.com wrote:

Mine is the 24kWh Gen 2, here is my JSON:

array(6) { ["status"]=> int(200) ["vehicleInfo"]=> array(1) { [0]=> array(5) { ["vin"]=> string(17) "snip" ["nickname"]=> string(4) "Leaf" ["charger20066"]=> string(5) "false" ["telematicsEnabled"]=> string(4) "true" ["custom_sessionid"]=> string(110) "snip" } } ["vehicle"]=> array(1) { ["profile"]=> array(8) { ["vin"]=> string(17) "snip" ["gdcUserId"]=> string(0) "" ["gdcPassword"]=> string(0) "" ["encAuthToken"]=> string(64) "snip" ["dcmId"]=> string(12) "snip" ["status"]=> string(4) "true" ["statusDate"]=> string(17) "snip" ["nickname"]=> string(4) "Leaf" } } ["EncAuthToken"]=> string(80) "snip" ["CustomerInfo"]=> array(11) { ["UserId"]=> string(10) "snip" ["Language"]=> string(5) "en_GB" ["Timezone"]=> string(12) "Europe/Paris" ["RegionCode"]=> string(2) "NE" ["OwnerId"]=> string(10) "snip" ["EMailAddress"]=> string(21) "snip" ["Nickname"]=> string(4) "Leaf" ["Country"]=> string(2) "GB" ["VehicleImage"]=> string(47) "/content/language/default/images/img/ph_car.jpg" ["UserVehicleBoundDurationSec"]=> string(9) "snip" ["VehicleInfo"]=> array(9) { ["VIN"]=> string(17) "snip" ["DCMID"]=> string(12) "snip" ["SIMID"]=> string(20) "snip" ["NAVIID"]=> string(12) "snip" ["EncryptedNAVIID"]=> string(32) "snip" ["MSN"]=> string(15) "snip" ["LastVehicleLoginTime"]=> string(0) "" ["UserVehicleBoundTime"]=> string(20) "snip" ["LastDCMUseTime"]=> string(17) "snip" } } ["UserInfoRevisionNo"]=> string(1) "1" }

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ScottHelme/AlexaNissanLeaf/pull/6#issuecomment-267848244, or mute the thread https://github.com/notifications/unsubscribe-auth/AFy_vgJZVku_GO7_FZCIt-vZ78j7CO16ks5rJaYQgaJpZM4LQGlG .

-- Phil

-- Phil

ScottHelme commented 7 years ago

This change would not be compatible with both vehicles though would it?

ScottHelme commented 7 years ago

Oh wait, yes it would, ignore me :)

ScottHelme / AlexaNissanLeaf

Initial fixes #6