.Net Standard, Minecraft query support.

ScottKaye / CoreRCON

Source RCON protocol and LogAddress receiver on .NET Core

MIT License

30 stars 17 forks source link

.Net Standard, Minecraft query support. #7

Closed CodingContraption closed 7 years ago

CodingContraption commented 7 years ago

Hello,

To be able to use this library for minecraft (query was not compatible) I have made some changes to add support for minecraft queries. In the process I also changed the solution to csproj and converted the project to .NET Standard 1.6.

I understand my changes are quite radical, feedback is welcome since I am still a junior developer.

ScottKaye commented 7 years ago

Looks great! Thank you very much for adding this, I'm sure a lot of people will be very appreciative as well 👍 I'm a junior dev myself, but I'd just like to say that your code looks great.

Your changes are now available in version 3.0.0.

ScottKaye commented 7 years ago

The project is now licensed under MIT per #9 - hopefully this is alright with you @CodingContraption . If not, please let me know and we can figure something out.

CodingContraption commented 7 years ago

No problem at all, don't worry about it.