When there are many tabs open, the tab heading list needs to be scrollable

ScottLogic / kdb-boothroyd

a prototype re-implementation of KDB Studio using JavaScript and Electron

Apache License 2.0

5 stars 2 forks source link

When there are many tabs open, the tab heading list needs to be scrollable #44

Open ColinEberhardt opened 3 years ago

OiNutter commented 3 years ago

Assuming we're talking about server tabs this is kind of implemented. It's not scrolling, it's using the overflow item setting built into a Pivot control. This does seem to be the FluentUI way of dealing with too many items on a Pivot

ColinEberhardt commented 3 years ago

Currently if you have lots of tabs open, this happens ...

OiNutter commented 3 years ago

Hmm, that looks like it's not triggering the overflow items. Can you double check line 124 of MainInterface.tsx please? should say overflowBehaviour="menu"

OiNutter commented 2 years ago

Is this still happening?

ColinEberhardt commented 2 years ago

Yes, this is still an issue.

OiNutter commented 2 years ago

This is very strange, I've literally added a test for this which seems to pass (assuming you can connect to the servers, which is a whole other thing). Are you on Mac, Windows or Linux?