ScottLogic / kdb-boothroyd

a prototype re-implementation of KDB Studio using JavaScript and Electron
Apache License 2.0
5 stars 2 forks source link

dev console should not pop up in release build #65

Closed gyorokpeter closed 2 years ago

gyorokpeter commented 2 years ago

By this I'm referring to the exe file created by "npm run dist". Or if there is already an alternative command to achieve this, it should be documented in the readme.

OiNutter commented 2 years ago

How did you build the files before creating the exe? If you've previously just run npm run dev:react and npm run dev:electron then the app will be built for development not release. As mentioned in #66 the npm run dist command just packages the built files.

gyorokpeter commented 2 years ago

This is also not fixed by my attempt with "npm run build".

OiNutter commented 2 years ago

Did this get fixed by adding in cross-env to the commands for building a release?

gyorokpeter commented 2 years ago

Yes.