ScottLogic / kdb-boothroyd

a prototype re-implementation of KDB Studio using JavaScript and Electron
Apache License 2.0
5 stars 2 forks source link

Unsaved changes handler causing multiple re-renders #92

Open OiNutter opened 2 years ago

OiNutter commented 2 years ago

The call to setConnections on Line 218 of MainInterface.tsx is causing the results window (and possibly the entire ServerInterface chain) to re-render. It's not breaking anything at the moment but it's obviously not very performant so we'll want to address it when we can.

A possible suggestion could be to store a seperate map of connection id to unsaved changes boolean so we can update that without causing a re-render?