ScottLogic / prompt-injection

Application which investigates defensive measures against prompt injection attacks on an LLM, with a focus on the exposure of external tools.
MIT License
15 stars 10 forks source link

Details (summary) buttons hover and redesign #783

Closed dhinrichs-scottlogic closed 5 months ago

dhinrichs-scottlogic commented 7 months ago

Feature Request

Description

Give the details buttons of the config hover styles.

Additional context

Acceptance criteria

Please test using NVDA and Firefox

GIVEN a screen reader user moves through the configurations WHEN they land on the "Defence Configuration" or "details" button THEN the visual icon is not announced, but the state of the button (expanded/collapsed) is announced .

chriswilty commented 7 months ago

@dhinrichs-scottlogic I made a comment on Anna's PR https://github.com/ScottLogic/prompt-injection/pull/781#discussion_r1462995384 about creating a reuseable component, so you'd only need to put the styles in one place. Following that PR, we now have some duplicated styles for the Defence and Model config details elements, so perhaps you could tackle it here instead.