Closed dhinrichs-scottlogic closed 5 months ago
@dhinrichs-scottlogic I made a comment on Anna's PR https://github.com/ScottLogic/prompt-injection/pull/781#discussion_r1462995384 about creating a reuseable component, so you'd only need to put the styles in one place. Following that PR, we now have some duplicated styles for the Defence and Model config details elements, so perhaps you could tackle it here instead.
Feature Request
Description
Give the details buttons of the config hover styles.
details
andsummary
elements to custom buttons. Turns out semantic html isn't always better. Here's an article on this.Additional context
Acceptance criteria
Please test using NVDA and Firefox
GIVEN a screen reader user moves through the configurations WHEN they land on the "Defence Configuration" or "details" button THEN the visual icon is not announced, but the state of the button (expanded/collapsed) is announced .