search

ScottLogic / prompt-injection

Application which investigates defensive measures against prompt injection attacks on an LLM, with a focus on the exposure of external tools.
MIT License
15 stars 10 forks source link

Too many options to close the same modal #786

Closed dhinrichs-scottlogic closed 2 months ago

dhinrichs-scottlogic commented 7 months ago

Feature Request

Description

Many of our modals can be dismissed with the close button at the top right, as well as an "Okay" or "Cancel" button. It can be confusing to have multiple ways to dismiss the same modal, so this needs to be redesigned

chriswilty commented 7 months ago

@dhinrichs-scottlogic Can this go into one of your milestones, so we don't lose track of it?

chriswilty commented 2 months ago

Will not fix, as this is almost redundant following the multi-page modal redesign (#578). The "reset" modals still have two close buttons, but it's open to debate whether or not it's a bad thing. As it stands, all story modals have the same look'n'feel so it feels worse to remove the top-right close button for just these two modals.