742 stops model config slider updating on every step

ScottLogic / prompt-injection

Application which investigates defensive measures against prompt injection attacks on an LLM, with a focus on the exposure of external tools.

MIT License

15 stars 10 forks source link

742 stops model config slider updating on every step #796

Closed pmarsh-scottlogic closed 7 months ago

pmarsh-scottlogic commented 7 months ago

Notes

instead of submitting the new value on every onChange event, we now update the component's value state variable on every onChange event, and only submit it on the onChangeCommitted event.

Checklist

Have you done the following?

[x] Linked the relevant Issue
[ ] Added tests
[x] Ensured the workflow steps are passing

pmarsh-scottlogic commented 7 months ago

I note that onChangeCommitted only fires on mouseup, not on (arrow) keyup, so if a keyboard user holds down an arrow key, we still see multiple events fired.

That's just a MUI Slider implementation choice though - the HTML spec does not state when the change event should fire for a native <input type="range">, neither for mouse nor keyboard events, so MUI don't have any native spec to copy.

the only way I can see to fix that is to have a button to press when we're done configuring...