Previously, when a user changed or reset the text or number inputs of the defence and model configurations, a message would pop up for 3 seconds to indicate to the user that the change has been made. This can easily be missed, which is why I moved this message to the chat window instead, where the user already gets updates when defences get toggled on/off.
Validation error messages remain underneath the input controls, and text/number inputs are now validated onChange rather than onBlur, giving users the chance to change their input. Error messages do not disappear after a time delay, but only disappear when the input is changed to a valid value. The error message field is announced to screen readers through aria-live="polite".
If a user keeps invalid input and commits it (by pressing enter or changing focus), the message will reset on to the previously valid value.
Screenshots
Notes
changed two key/value pairs of the enum DEFENCE_ID: FILTER_USER_INPUT to INPUT_FILTERING and FILTER_BOT_OUTPUT to OUTPUT_FILTERING
This is the second try to complete this ticket
For documentation, I addressed the following issues mentioned in the previous PR reviews:
kept validation where it existed, displaying an error message on the frontend onChange,
used addInfoMessage instead of addChatMessage
moved validation into DefenceConfigurationInput (not DefenceConfiguration after all, based on discussions and a few tries)
added error styling for the inputs and error message that persists beneath the input
created separate function (addConfigUpdateToChat) to ensure no duplication when resetting and updating a config
Concerns
Due to the naming of the Information Defence, "defence" is repeated in the chat when it is activated, there is already https://github.com/ScottLogic/prompt-injection/issues/776 to address this. For the update info messages I did not include the word "defence"
The defence.name and the DEFENCE_ID are slightly different q/a LLM versus qa LLM. I couldn't change the enum to include the "/" in the enum key (which is what's being used in the function to update the config) and I didn't want to create a special conditional to change the output to the UI. Personally I think the difference between q/a and qa is acceptable for now.
Description
Second try at this ticket. Started again from scratch. Previous PR can be found here: https://github.com/ScottLogic/prompt-injection/pull/778
Previously, when a user changed or reset the text or number inputs of the defence and model configurations, a message would pop up for 3 seconds to indicate to the user that the change has been made. This can easily be missed, which is why I moved this message to the chat window instead, where the user already gets updates when defences get toggled on/off.
Validation error messages remain underneath the input controls, and text/number inputs are now validated onChange rather than onBlur, giving users the chance to change their input. Error messages do not disappear after a time delay, but only disappear when the input is changed to a valid value. The error message field is announced to screen readers through aria-live="polite".
If a user keeps invalid input and commits it (by pressing enter or changing focus), the message will reset on to the previously valid value.
Screenshots
Notes
This is the second try to complete this ticket
For documentation, I addressed the following issues mentioned in the previous PR reviews:
Concerns
Checklist
Have you done the following?