ScottLogic / prompt-injection

Application which investigates defensive measures against prompt injection attacks on an LLM, with a focus on the exposure of external tools.

MIT License

13 stars 9 forks source link

782 give every modal a header with title and close button #829

Closed dhinrichs-scottlogic closed 5 months ago

dhinrichs-scottlogic commented 5 months ago

Description

Every Modal now has a heading and a close button with the text "close" and an x icon.

Screenshots

Notes

new OverlayHeader component
new x icon svg
style update for DocViewer and Handbook

Concerns

I took the svg from here and then removed anything ~~I didn't understand~~ that seemed unnecessary, so would be great to double check that I didn't remove anything important.

Checklist

Have you done the following?

[x] Linked the relevant Issue
[x] Added tests
[x] Ensured the workflow steps are passing

pmarsh-scottlogic commented 5 months ago

Visual changes look cracking by the way! Should've led with that 😅

dhinrichs-scottlogic commented 5 months ago

@pmarsh-scottlogic Chris did some css magic, the issue with the scrollbar and margins should be fixed and future-proofed now.