ScottMaclure / cv

My personal CV.
http://scott.maclure.info/cv
MIT License
2 stars 1 forks source link

Add key prop to all components #11

Closed ScottMaclure closed 8 years ago

ScottMaclure commented 8 years ago

Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <h1>. See https://fb.me/react-warning-keys for more information.

ScottMaclure commented 8 years ago

Current output:

$ npm test

> scott-cv@2.3.3 test C:\Users\scott\dev\scott-cv
> jest --coverage

Using Jest CLI v0.10.2, jasmine2
Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <div>. See https://fb.me/react-warning-keys for more information.
 PASS  __tests__\components\EducationItem-test.js (0.469s)
Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <div>. See https://fb.me/react-warning-keys for more information.
Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <footer>. See https://fb.me/react-warning-keys for more information.
 PASS  __tests__\components\Footer-test.js (0.188s)
Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <div>. See https://fb.me/react-warning-keys for more information.
 PASS  __tests__\components\Skills-test.js (0.125s)
Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <div>. See https://fb.me/react-warning-keys for more information.
 PASS  __tests__\components\Work-test.js (0.109s)
Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <div>. See https://fb.me/react-warning-keys for more information.
Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <ul>. See https://fb.me/react-warning-keys for more information.
 PASS  __tests__\components\SkillsItem-test.js (0.078s)
Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <div>. See https://fb.me/react-warning-keys for more information.
 PASS  __tests__\components\PlainText-test.js (0.078s)

Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <div>. See https://fb.me/react-warning-keys for more information.

Warning: Each child in an array or iterator should have a unique "key" prop. Check the top-level render call using <dl>. See https://fb.me/react-warning-keys for more information.
 PASS  __tests__\components\Languages-test.js (0.567s)

 PASS  __tests__\components\WorkItem-test.js (0.628s)
36 tests passed (36 total in 8 test suites, run time 68.552s)
-------------------|----------|----------|----------|----------|----------------|
File               |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
-------------------|----------|----------|----------|----------|----------------|
 components\       |      100 |      100 |      100 |      100 |                |
  EducationItem.js |      100 |      100 |      100 |      100 |                |
  Footer.js        |      100 |      100 |      100 |      100 |                |
  Languages.js     |      100 |      100 |      100 |      100 |                |
  PlainText.js     |      100 |      100 |      100 |      100 |                |
  Skills.js        |      100 |      100 |      100 |      100 |                |
  SkillsItem.js    |      100 |      100 |      100 |      100 |                |
  Work.js          |      100 |      100 |      100 |      100 |                |
  WorkItem.js      |      100 |      100 |      100 |      100 |                |
-------------------|----------|----------|----------|----------|----------------|
All files          |      100 |      100 |      100 |      100 |                |
-------------------|----------|----------|----------|----------|----------------|
ScottMaclure commented 8 years ago

Working now:

$ npm test

> scott-cv@2.3.3 test C:\Users\scott\dev\scott-cv
> jest --coverage

Using Jest CLI v0.10.2, jasmine2
 PASS  __tests__\components\Languages-test.js (0.672s)
 PASS  __tests__\components\EducationItem-test.js (0.719s)
 PASS  __tests__\components\WorkItem-test.js (0.797s)
 PASS  __tests__\components\Footer-test.js (0.312s)
 PASS  __tests__\components\Skills-test.js (0.266s)
 PASS  __tests__\components\Work-test.js (0.281s)
 PASS  __tests__\components\PlainText-test.js (0.109s)
 PASS  __tests__\components\SkillsItem-test.js (0.11s)
36 tests passed (36 total in 8 test suites, run time 4.094s)
-------------------|----------|----------|----------|----------|----------------|
File               |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
-------------------|----------|----------|----------|----------|----------------|
 components\       |      100 |      100 |      100 |      100 |                |
  EducationItem.js |      100 |      100 |      100 |      100 |                |
  Footer.js        |      100 |      100 |      100 |      100 |                |
  Languages.js     |      100 |      100 |      100 |      100 |                |
  PlainText.js     |      100 |      100 |      100 |      100 |                |
  Skills.js        |      100 |      100 |      100 |      100 |                |
  SkillsItem.js    |      100 |      100 |      100 |      100 |                |
  Work.js          |      100 |      100 |      100 |      100 |                |
  WorkItem.js      |      100 |      100 |      100 |      100 |                |
-------------------|----------|----------|----------|----------|----------------|
All files          |      100 |      100 |      100 |      100 |                |
-------------------|----------|----------|----------|----------|----------------|
ScottMaclure commented 8 years ago

Need to test JsonResume component also.