issues
search
ScotterMonk
/
scottswain
This project is in support of efforts to hire python engineers.
MIT License
0
stars
0
forks
source link
Issue 17-Pre-demo touch-up
#24
Closed
ScotterMonk
closed
2 days ago
ScotterMonk
commented
2 days ago
Background/need
Assuming the application will serve the following two purposes:
The app will be scrutinized in order to determine how well the developer will fit in at Victory CTO, from the perspective of:
Approach to the various issues.
Coding style.
Trade-off choices.
Writing/communication.
The app may be used as a foundation to build upon for a near-future larger application, considering:
Scaling.
Security.
Useability.
Performance.
Code management (clear and well-organized code).
Acceptance Criteria/Completed
Scrutinize and modify tests to use status codes consistently instead of messages returned from route defs.
For user_routes.py:
Consistent and verbose comments/comment structure.
Changed out all http status codes for more readable version.
Added a show all roles (roles_show) route to help with testing and, of course, be useful for the full app later.
Improved formatting of output with more logging.debugs, linefeeds, and labels in various spots.
For test_auth.py:
Changed out all http status codes for more readable version.
Added test_delete_user.
Changed "test_login_invalid_user" to "test_login_invalid_password".
Added test_login_non_existent_user.
Added test_show_user_profile.
For user_service.py, mods to password checking function.
For README.md and README-Windows.md, minor changes.
For models.py, minor cosmetic spacing changes.
For run.py, commented out database table reporting.
Ideas for future
Add more tests to include every permutation of every route.
Add logging to tests.
Add more error checking.
Move logger config to a separate file so it can be referenced by multiple modules.
Background/need
Assuming the application will serve the following two purposes:
Acceptance Criteria/Completed
Ideas for future