search

ScottishCovidResponse / SCRCIssueTracking

Central issue tracking repository for all repos in the consortium
6 stars 0 forks source link

Amend compartmental model to match central consortium plan. #307

Closed magicicada closed 4 years ago

magicicada commented 4 years ago

SCRC has identified a common compartmental model that is a little different than what we have been using. We've been asked to amend our models so that running with that new structure is at least an option. In addition to changing the transitions, this will also need us to change the defs of what is considered "infectious". I suggest we start passing a list of states that are considered infectious to the basicSimulation function as a parameter - @aflag Any thoughts?

github-actions[bot] commented 4 years ago

Heads up @magicicada @bobturneruk @aflag @nathan-cummings-ukaea @WPettersson @alex-konovalov - the "Simple Network Sim" label was applied to this issue.

aflag commented 4 years ago

Sounds good, in the changes I was doing this morning I actually had this: 

SUSCEPTIBLE_STATE = "S"
EXPOSED_STATE = "E"
INFECTIOUS_STATES = ["I", "A"]

We can easily make that a parameter of the basicSimulation function

WPettersson commented 4 years ago

For forward compatibility, may I suggest

SUSCEPTIBLE_STATES = ["S"]
EXPOSED_STATES = ["E"]
INFECTIOUS_STATES = ["I", "A"]

It makes things more consistent, and also makes it trivial to support any further changes.

bobturneruk commented 4 years ago

Need agreement on compartment names at SCRC.