search

ScottishCovidResponse / SCRCIssueTracking

Central issue tracking repository for all repos in the consortium
6 stars 0 forks source link

Fix segfault when parameter value is blank #563

Closed ianhinder closed 4 years ago

ianhinder commented 4 years ago

Running with "nchain=" caused a segfault for me, a while back. Check whether this is still the case, and fix the code. The string manipulation code can probably be replaced with standard functions.

github-actions[bot] commented 4 years ago

Heads up @chrispooley @ianhinder - the "CoronaPMCMC" label was applied to this issue.

rwj11 commented 4 years ago

I don't get a segfault, but do see an ugly-looking abort due to an uncaught exception escaping.

ianhinder commented 4 years ago

Can you add a nicer exception handler?

rwj11 commented 4 years ago

I'll add a minimal handler just to make things look less nasty if this specific error occurs. There should probably be a feature ticket (and associated discussion) about general policy for error handling?

ianhinder commented 4 years ago

Yes - would you mind creating such a ticket and making a suggestion? Thanks!

ianhinder commented 4 years ago

Addressed in https://github.com/ScottishCovidResponse/CoronaPMCMC/pull/4.