search

ScottishCovidResponse / SCRCIssueTracking

Central issue tracking repository for all repos in the consortium
6 stars 0 forks source link

Files in data directory should not be modified #605

Closed ianhinder closed 4 years ago

ianhinder commented 4 years ago

The data directory should be treated as an input directory, and all output should go into the output directory. Otherwise you cannot run more than one run at once, and it's anyway just very confusing. Currently, running examples/sim.toml overwrites the repository files 

    examples/Data_example/Q_flow_all_data.txt
    examples/Data_example/Q_local_home_data.txt

These are specified in

genQoutput= {localhome="Q_local_home_data.txt", flowall="Q_flow_all_data.txt"}

in sim.toml. Can these just be written to outputdir instead? They don't seem to be read back in by the code, so is this just for informational purposes?

ianhinder commented 4 years ago

PR in https://github.com/ScottishCovidResponse/BEEPmbp/pull/13.

ianhinder commented 4 years ago

This has now been fixed.