search

ScottishCovidResponse / SCRCIssueTracking

Central issue tracking repository for all repos in the consortium
6 stars 0 forks source link

Improve encapsulation #691

Open ianhinder opened 4 years ago

ianhinder commented 4 years ago

Many of the classes have a lot of public member variables. This is generally a bad sign, as it means that internal implementation details cannot be hidden inside methods. We could first make all variables private that can be, and see what is accessing the public ones, and whether such code can be moved into the class as a new method.

github-actions[bot] commented 4 years ago

Heads up @chrispooley @ianhinder @rwj11 - the "BEEPmbp" label was applied to this issue.