ScottishCovidResponse / SCRCIssueTracking

Central issue tracking repository for all repos in the consortium
6 stars 0 forks source link

Fix compiler warnings #703

Closed ianhinder closed 4 years ago

ianhinder commented 4 years ago

We have some compiler warnings again. See https://github.com/ScottishCovidResponse/BEEPmbp/actions/runs/183411879. These should be fixed.

github-actions[bot] commented 4 years ago

Heads up @chrispooley @ianhinder @rwj11 - the "BEEPmbp" label was applied to this issue.

rwj11 commented 4 years ago

Closed at https://github.com/ScottishCovidResponse/BEEPmbp/pull/19 One clang-analyzer warning remains on llvm 6.0, which does not appear using llvm 10.0.

ianhinder commented 4 years ago

I've update CI to use clang-tools-10, and the warning indeed goes away. See https://github.com/ScottishCovidResponse/BEEPmbp/actions/runs/189132525.

rwj11 commented 4 years ago

Great, thanks.