search

ScottishCovidResponse / SCRCIssueTracking

Central issue tracking repository for all repos in the consortium
6 stars 0 forks source link

Git commit with quotes breaks versioning logger #730

Closed peter-t-fox closed 4 years ago

peter-t-fox commented 4 years ago

If a git commit message has quotes in it, it will prevent the Git.cpp file from building. This is because the quotes are copied verbatim by the git_watcher CMake script into the C++ code, resulting in a malformed string.

Simplest solution is to remove the commit message functionality from the Git.cpp file, as we don't use it, and are unlikely to ever need it.

github-actions[bot] commented 4 years ago

Heads up @thibaud-porphyre @peter-t-fox - the "Covid19_EERAModel" label was applied to this issue.