search

ScottishCovidResponse / data_pipeline_api

API to access the data pipeline
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Fix Semver and Pytest deprecation warnings #112

Closed kzscisoft closed 3 years ago

kzscisoft commented 3 years ago

This fixes the deprecation warnings given by PyTest and Semver:

pytest.yield_fixture -> pytest.fixture semver.parse_version_info -> semver.VersionInfo.parse

Closes https://github.com/ScottishCovidResponse/SCRCIssueTracking/issues/778 Closes https://github.com/ScottishCovidResponse/SCRCIssueTracking/issues/777

codecov[bot] commented 3 years ago

Codecov Report

Merging #112 (b60ac76) into master (df05cd6) will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #112   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
- Complexity      180      181    +1     
=========================================
  Files            64       64           
  Lines          2217     2217           
  Branches         38       38           
=========================================
  Hits           1701     1701           
  Misses          484      484           
  Partials         32       32
Impacted Files Coverage Δ Complexity Δ
data_pipeline_api/registry/common.py 97.43% <ø> (ø) 0.00 <0.00> (ø)
data_pipeline_api/registry/upload_data_product.py 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
data_pipeline_api/registry/upload.py 81.72% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df05cd6...b60ac76. Read the comment docs.

DennisReddyhoff commented 3 years ago

No deprecation warnings on running Pytest but got these:

image

Not totally sure what its related to, will discuss with Bob shortly

bobturneruk commented 3 years ago

We probably don't need the egg stuff?

bobturneruk commented 3 years ago

Suggest:

bobturneruk commented 3 years ago

Merge if passes locally in Linux

kzscisoft commented 3 years ago

@bobturneruk are we ok to press "merge" now then?

bobturneruk commented 3 years ago

Once @DennisReddyhoff has make changes as per comments above. In future we should keep branches focussed and separate. I suggest that ordinarily the originator of a PR should do the merge, but in this case best if it's Dennis.