CORS Regex

[saifulkhan]

For example test: https://deploy-preview-119--rampvis-ui-development.netlify.app/page?id=6181746e3f35852412f6b3b4

[kachkaev]

Happy to submit a PR for that to unblock us

[saifulkhan]

It will be great :)

[kachkaev]

Done in #27

[saifulkhan]

Looks like the issue is still there.

Test cases:

1. infrastructure-api (Javascript): Open and see if the list of dashboards are loaded https://deploy-preview-119--rampvis-ui-development.netlify.app/dashboard

2. data-api (Python): Open and see if the data is being served https://deploy-preview-119--rampvis-ui-development.netlify.app//stat/v1/data/?product=phe&component=newPeopleVaccinatedThirdInjectionByPublishDate&format=long

The CORS check in the Python API happens in: https://github.com/ScottishCovidResponse/rampvis-api/blob/main/data-api/app/main.py#L19 We need to review this part of the code too.

[kachkaev]

@saifulkhan what is the value of our env var? Do we have *--rampvis-ui-development.netlify.app in the list of origins?

I did not know about the python routes, not sure what to suggest there!

[saifulkhan]

Yes, I shared the config (it's a private repo) folder with you. https://github.com/saifulkhan/rampvis-config/blob/main/production.json

[kachkaev]

Right. Looks like we’ll need to enable allow_origin_regex in python change the config to some regex 🤔

https://fastapi.tiangolo.com/tutorial/cors/

JS implementation would need to change too for parity.

[kachkaev]

Let me give it a try now

[saifulkhan]

Yes, I wonder what should be the value of allow_origin_regex, "*--rampvis-ui-development.netlify.app"?

[kachkaev]

28

[kachkaev]

🤞