search

ScottishRoss / little_victories

BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

feature/victoryIcons: building on develop branch #29

Closed saksham-gt closed 2 years ago

saksham-gt commented 2 years ago

User can now add Victory Icons when they register a victory. This version is build on top of develop branch and hence doesn't have Twitter Authentication implemented.

ScottishRoss commented 2 years ago

That's better! I was just replying to you on your other PR. I'll clone and check out your PR tomorrow when I have some time.

saksham-gt commented 2 years ago

Okay, also can you review the Facebook sign-in PR by tomorrow EOD? I'll make the PR within 10 hours.

ScottishRoss commented 2 years ago

I promise to review by EOD tomorrow, I want to make sure you get your Hacktoberfest credit.

saksham-gt commented 2 years ago

Also, Can you make a branch in your repo for the Facebook login feature like you made for Twitter? I'll make the PR in that branch itself so that it won't interrupt the flow of other feature.

ScottishRoss commented 2 years ago

Tagged as accepted. Will review in more detail later.

saksham-gt commented 2 years ago

This is the merge request where the user is deleted in the firebase. I'll set up the whole state management for this app and update the UI later. @ScottishRoss