search

ScottyB / ac-js2

Javascript auto-completion in Emacs using Js2-mode's parser and Skewer-mode.
123 stars 8 forks source link

Couple of minor suggestions #1

Closed purcell closed 11 years ago

purcell commented 11 years ago

First off, this is a nice piece of work - thanks for publishing.

Regarding M-., you can add backwards navigation and generally make this work more neatly by using ring-insert and pop-tag-mark -- take a look at https://github.com/purcell/elisp-slime-nav/blob/master/elisp-slime-nav.el#L93 for an example.

Secondly, I spotted a couple of typos in the code: search for "funtion" and "evalute".

Cheers!

-Steve

ScottyB commented 11 years ago

Thanks for the encouragement and spotting the typos.

I didn't know about backwards navigation in elisp-slime-nav even though I do use that package. Made the changes to ac-js2, much nicer :).

purcell commented 11 years ago

I stole the technique from the Slime source... :-)