search

ScottyLabs / cmueats

Progressive web app to keep track of all of the CMU dining locations and when they're available
https://cmueats.com
5 stars 17 forks source link

Panel rendering is pretty slow #416

Open cirex-web opened 10 months ago

cirex-web commented 10 months ago

Expected Behavior

Rendering a single page should take ~16ms, but the panel page takes 20+ ms. This is quite bad when compared to the map page which has a render time of .5ms. (Performance should probably not be this bad when all we're displaying is a grid with some text)

image image

Steps to Reproduce

.

Device Information

.

GhostOf0days commented 10 months ago

We may be able to see some performance increases in general if we switch our Virtual DOM to Million.js (see #96) and switch our runtime to Bun (this would be a more massive undertaking).

cirex-web commented 10 months ago

or perhaps just use plain JSX rather than a UI framework?

GhostOf0days commented 10 months ago

Yeah, but, either way, I eventually wanted to switch out the Virtual DOM and runtime to Million.js and Bun for a long time. Million.js just wasn't stable back then although it is now. Bun is stable, but, it requires WSL for Windows since they're still working on a stable build for Windows (currently, unstable Windows build passes around 33% of Bun's internal tests).

GhostOf0days commented 10 months ago

So kind of could help kill two birds with one stone (i don't remember if that's the saying lol).