export and show AWS_ACCOUNT_NAME and AWS_ASSUMED_ROLE

Scout24 / afp-cli

CLI for the AWS Federation Proxy

Apache License 2.0

13 stars 8 forks source link

export and show AWS_ACCOUNT_NAME and AWS_ASSUMED_ROLE #21

Closed matey-jack closed 9 years ago

matey-jack commented 9 years ago

See discussion in #20. Works with --show, with --export, and in subshell. Does not change --write.

Since the coverage check didn't like unit tests for module cli, I moved the tested functions to a new module.

I also hope that you like unit tests without mocks as much as I do. ;)

mriehl commented 9 years ago

You can use pyb -v or set the verbose property in build.py to see unit test errors (in text, not XML)

Also :+1: for getting rid of mocks!

matey-jack commented 9 years ago

PR is finished from my point and I'd be glad if someone would merge it. Test Coverage has increased with this and the coverage plugin only reports a decrease in one file because I moved some code out of there.

esc commented 9 years ago

@matey-jack github reckons there are still some conflicts, could you rebase and fix the conflicts please.

matey-jack commented 9 years ago

ok, done.

esc commented 9 years ago

Thanks for this, I'll get it merged up tomorrow and cut a new release unless someone beats me to it!

esc commented 9 years ago

Merging now.

esc commented 9 years ago

@matey-jack thanks for the feedback, I merged the pull-request and released a new version: 1.2.0 -- it is already available from PyPI so you can use:

pip install -U afp-cli

to upgrade.

schlomo commented 8 years ago

Thanks a lot!

coveralls commented 7 years ago

Coverage decreased (-6.2%) to 87.5% when pulling 92559aea175bc2cebf41e3df4a6c96648aa63365 on matey-jack:master into 32c0a75fdd068222783abc6878c58a956acddb9a on ImmobilienScout24:master.