Scout24 / afp-cli

CLI for the AWS Federation Proxy
Apache License 2.0
13 stars 8 forks source link

Keychain #27

Closed esc closed 8 years ago

esc commented 8 years ago

This implements support for the python 'keychain' module.

esc commented 8 years ago

This is experimental support for the 'keychain' module:

https://pypi.python.org/pypi/keyring

It still has some caveats, things to think about:

I'd appreciate if some of the tech-savy ones amongst you could give it a shot and provide feedback.

esc commented 8 years ago

Also, I had to vendor bottledaemon again, because:

https://github.com/ImmobilienScout24/afp-cli/commit/900dec1dd33fa9fbd30c561fadc775924b1a0623

esc commented 8 years ago

And oh yeah, sorry, but I didn't have any time to write tests, but will before the merge. evilgrin

mriehl commented 8 years ago

@esc you are my hero. As an end user I am using a global install of api-cli anyway so reliance on system site packages is not an issue for me.

esc commented 8 years ago

@mriehl no worries! It was trivial to implement once I understood where the packages come from and how to install them

esc commented 8 years ago

@mriehl also, let me know if it works for you!

esc commented 8 years ago

Regarding the coverage and tests, the cli.py file is excluded from the coverage, but contains a bunch of code.. should probably deal with this somehow.

esc commented 8 years ago

Guess I'll be merging this and refactoring it with more pull-requests.