search

Scout24 / afp-cli

CLI for the AWS Federation Proxy
Apache License 2.0
13 stars 8 forks source link

Change api url config file option #37

Open esc opened 8 years ago

esc commented 8 years ago

Does anyone have any issues changing the api_url config item to api-url?

schlomo commented 8 years ago

I would like to have an option to only set the hostname part of the URL - leaving the protocol and path unchanged. ATM I need to set the complete URL even if I only want to change the hostname of the server.

esc commented 8 years ago

those are separate issues, mind you.

schlomo commented 8 years ago

Yes? My issue is you want me to change my config and I - the end user - voice my opinion about what kind of change I actually need :-)

So, maybe instead of changing the api_url key you add a new key called api-host (or something like this) that solves my problem and probably the problem of all the other people who ever had to change the api_url key :-)

schlomo commented 8 years ago

See also #39, though I would love to have a corresponding config item as well.

esc commented 8 years ago

@schlomo how do we deal with this? Would propose to change this, when we change to v2

esc commented 8 years ago

But maybe we can deprecate it already?

schlomo commented 8 years ago

Sure, why not add a deprecation warning for the old form? In 1-2 months we can then remove it.

schlomo commented 8 years ago

And advice people to switch to the new server variable which will probably obsolete the need for people to change the api-url variable altogether.

esc commented 8 years ago

Yes, but only if it is found in config, right? I don't want a warning if I am overriding things on the command-line.

schlomo commented 8 years ago

If you use the old command line argument then you should be warned. Otherwise not.