search

Scout24 / afp-cli

CLI for the AWS Federation Proxy
Apache License 2.0
13 stars 8 forks source link

Replace afp with afpv2 #38

Open esc opened 8 years ago

esc commented 8 years ago

What are every ones thoughts on this one?

mriehl commented 8 years ago

I'd do a 2-step migration:

Step 1 would allow to find out who is affected (eG numerous scripts). If no one complains then step 2 can be done earlier. People whose workflow is disrupted by the change can still keep using afpv1 but will know that they need to adapt their scripts / workflow.

esc commented 8 years ago

Okay, maybe next tuesday then.

esc commented 8 years ago

Do you know of any scripts that use afpv1?

mriehl commented 8 years ago

We have some, but we can simply change them. I don't have any problems with a hard migration. But who knows what's out there ;)

esc commented 8 years ago

I'd like to come and see some of those scripts, wasn't expecting anyone to automate on afp-cli.

schlomo commented 8 years ago

Can we rename the subshell command to just shell? It is shorter and IMHO clear what it will do.

schlomo commented 8 years ago

Please add an Examples section to the --help command, e.g. eval $(afpv2 export account-name). This will help our users to quickly understand how to use it.

schlomo commented 8 years ago

Who needs the show subcommand? What use case does it serve? If this is for human consumption then I would suggest a format that is much more friendly on the eyes than KEY=VAL. And you also don't need quoting then :-)

If to keep show then probably JSON and YAML output will be more valuable to enable people to parse it in a machine readable format. jq to the rescue :-)

schlomo commented 8 years ago

The write subcommand should actually inform about which file was written and maybe warn if the file is world readable. Or offer setting safe perms automatically.