search

Scout24 / afp-cli

CLI for the AWS Federation Proxy
Apache License 2.0
13 stars 8 forks source link

Handle case when keyring password does not work #40

Open heroldus opened 8 years ago

heroldus commented 8 years ago

The keyring feature in #27 is really great. The only pitfall is that the password expiration will come soon. To tackle that you could re-prompt for a password if the authentication on the afp-server fails and save the new password in keyring

esc commented 8 years ago

Yes, we should think about improving the handling logic. Right now, it works 80% of the time but it would be nice to make it smarter and less, shall I say "hacky".

schlomo commented 8 years ago

A simpler solution might be to simple remove the cached password from the keyring if it did not work, together with a suitable message to the user like "Your cached password did not work - removing it. Please try again".

That would follow a "clean up after yourself" mind set without the need for a password changed dialog.

schlomo commented 8 years ago

ATM the workaround is to manually go to the password keyring and change/delete the password there. IMHO this is too non-obvious.

schlomo commented 8 years ago

Idea: Simply remove the stored password from keyring if it does not work.

This also covers other cases like the user entering a wrong password or unforeseen troubles.