search

Scout24 / c-bastion

Jump-host functionality, in the cloud.
6 stars 3 forks source link

Refactor_Makefile #11

Closed esc closed 8 years ago

esc commented 8 years ago

Remove the makefile and do (almost) everything with pybuilder.

esc commented 8 years ago

@schlomo initial stab at removing makefile, please review.

esc commented 8 years ago

I'd kill for a proper pybuilder docker plugin at this stage, the stuff I wrote is so flakey and I don't have the time to do it properly..

schlomo commented 8 years ago

@esc cool improvement. Do you want me to merge it now or keep improving?

esc commented 8 years ago

Will keep tweaking and answer questions tomorrow.

schlomo commented 8 years ago

Great. Maybe take a look at https://github.com/docker/docker-py to get rid of the sh usage. Let me know if I can help.

esc commented 8 years ago

I still have a few misconceptions about Docker Tags, probably confused by my existing knowledge about Git Tags... :/

esc commented 8 years ago

Okay, so proper versioning has been implemented. When building, it will first tag the local image with the current project version, then run the cram/system tests, and finally tag the image with latest, but only if the cram tests were sucessful.

esc commented 8 years ago

@schlomo I included another speciality you might like, now including the Travis build number in the version for fully repeatable builds.

schlomo commented 8 years ago

Tell me when you want me to merge - it looks good to me. My comments are all a matter of taste (except the one about system_tests depending on tag_latest)

esc commented 8 years ago

It's all fixed now. Even the system-tests use the current version and not latest.

esc commented 8 years ago

Think it is good to go.

esc commented 8 years ago

Merci!

schlomo commented 8 years ago

Thanks a lot - this is a really great improvement!

esc commented 8 years ago

yeah, no need to launch a product with a bunch of legacy!