Scout24 / restapi-php-sdk

SDK für PHP-Entwickler um die Arbeit mit der API von ImmobilienScout24 zu vereinfachen. Über die API erhält man Ergebnislisten, Objektdaten, uvm. von ImmobilienScout und kann diese Daten inhherhalb seines Webservice integrieren. Die Dokumentation zum SDK findet man unter https://github.com/Immocaster/php-sdk/wiki.
64 stars 46 forks source link

PHP7 Update #47

Closed checkerschaf closed 3 years ago

checkerschaf commented 6 years ago

Hey,

I'd recommend an update to PHP7 for maximum compatibility. Currently it's not working with many current releases of the most used frameworks.

Thanks!

all4pages commented 6 years ago

Yes with PHP7 no 3legged-oAuth

all4pages commented 6 years ago

I only got REQUEST and not APPLICATION in the Database when I tried to authentify the application. I found a error in the file: Imocaster/Data/Mysql.php In the function: saveApplicationToken() -304: 'APPLICATION','".$sToken."','".$sSecret."','0000-00-00 00:00:00.000000','".$sUser."' +304: 'APPLICATION','".$sToken."','".$sSecret."','1000-01-01 00:00:00.000000','".$sUser."'

The range from Datetime is 1000-01-01 00:00:00.000000 to 9999-12-31 23:59:59.999999 https://dev.mysql.com/doc/refman/5.7/en/datetime.html So the mysqli_query will never return true and so the script: Imocaster/Data/Rest.php with the funktion: registerAccess() will always fall back from function registerApplication() to registerRequest() and so you never get the application authentified.

I go on :-)

christianbarkowsky commented 5 years ago

successfully tested. Please fix the bug. 🙏