search

Scout24 / scout24-engineering-values-and-principles

Scout24 Engineering Values and Principles
146 stars 18 forks source link

Trunk based development for everyone? #5

Open JaycobA opened 5 years ago

JaycobA commented 5 years ago

Hey,

just stumbled over

We, as team members, continuously integrate our software changes with those of our teammates and push these changes to production automatically. To achieve this, we use trunk based development [...]

Is it reasonable / necessary to make that prescription? To me, how exactly people contribute code is like the work process itself: There is no definitive right or wrong answer, just the right answer for any given team. If teams want to work with pull requests for easier code reviews - why make that against the rules if the branches are sufficiently small?

To make my motivations clear: Both PPA teams are working trunk-based, so I'm not trying to change this out of selfish reasons. Just want to make sure we are not overly prescriptive here.

pgarbe commented 5 years ago

Trunk-based development and short-lived feature branches do not contradict each other. There are some studies around high-performance teams and one of the capabilities they have in common is trunk-based development. (for more insights I recommend the Accelerate book)