Scouter456 / Nether_Depths_Upgrade

7 stars 10 forks source link

Fabric 1.20 bugs and (mostly) suggestions #20

Open Ultimushadow opened 1 year ago

Ultimushadow commented 1 year ago

Hello, I have found a few things with the 3.0.0-1.20 version that may warrant some fixes, and a couple things that I thought could be added to. Here's what I've got so far:

Lack of config. Several of the things in your mod could benefit from user tweaking and so I suggest a config with spawn rates for the fish, spawn density for the structures, enable/disable certain features (fish/structures/potion effect/specific items, etc.)

Blazefish do not spawn around the nether fortress pieces. This has been recorded in another issue here. I would also say that lava underneath actual nether fortresses should also spawn the fish if possible, or that the pieces generate more often by default

Lava sponges appear to not be spawning, and the /locate structure command can't find them, so I'm unsure where the are meant to be obtained. I think they could potentially be added to the lava fishing treasure loot table (Along with the Eyeball Fish Eye and Nether Fortress Grouper Plate which arguably should not be considered fishing junk)

Soul Sucker Boots have an absurdly high defense but not much else going for them, making them so unbalanced it should probably be changed. I recommend that - They are treated as gold by piglins, come automatically enchanted with soul speed 3, and have a defense similar to iron. When on soul sand/soul soil - the player is unable to jump but has max knockback resistance and a slight regen effect as the boots grip on and feed from the souls in the terrain.

Fishing with the Lava Fishing Rod spawns the fish as an entity instead of an item. That is different from vanilla mechanics, but I think it's actually much better than how vanilla does it, however I suggest that the fish are temporarily stunned for a few seconds after being hooked so the player can actually catch/kill them and also that this is able to be toggled via config. Also, the fish rates are very skewed, if possible maybe the rates could reflect which biome the player is fishing in? I can't tell if this is already implemented so just ignore if it is.

Many nether fish seem to not have a use/have very limited use, so I figured I would throw in some suggestions. Lava Pufferfish have two good uses currently and don't need a change, but potentially lava vison could provide fire resistance as part of its effect in order to streamline the player experience. Alternatively, lava vision could be acquired from Eyeball fish instead, and Lava Pufferfish could be used to brew potions of wither to be used in combat. Obsidianfish could be used to craft crying obsidian as well, but both blocks can be acquired faster by mining/piglin trading. To stand out, I think the obsidianfish could be used to brew a potion which gives knockback resistance and immunity to environmental hazards (lava, fire, magma blocks, sweet berry bushes, cactus). I also think the obsidianfish should be able to survive in both lava and water, if possible. Searing Cod have potential for being used as furnace fuel, rather than dropping coal. Bonefish, rather than being used as bonemeal, could be right clicked into farmland to create a block which grows crops twice as fast, preferably using tags so other modded crops can be grown. Wither Bonefish could be used or crafted into an item which the player can right click on any small flower to turn it into a wither rose. Blazefish could be used to craft an item or potion which wards off blazes and stops them from targeting the player. Magma Cube Fish could be fed to frogs (via the item, not the fish) to get froglights. Probably easiest to just add a right click functionality to the item Glowdine could be used to give the player easier access to the glowing effect via brewing Soul Suckers could lower the players max health over time when in a certain radius, returning after the player gets far enough away Fortress Groupers at present already have a use by dropping plates, but the item itself doesn't have any use. They could either be crafted into nether bricks, or potentially used in an item that finds nether fortresses. Eyeball fish seemed like a better candidate for Lava Vision as stated before, but an alternative use could be to craft an item (rather than a potion) that has the same effect. Some sort of lava goggles that could go in the helmet slot (or goggles slot if curios/trinkets is installed).

The mods adds a tag called "Nether Salad Foods" which is completely unused but has a lot of potential. All the fish could be prepared into meals as well as the items in the tag.

It would be interesting to see some kind of difference under the surface between the biomes. As of right now, the basalt deltas are very identifiable because they just generate like that, but potentially the Warped Forest could have a higher density of Warped Kelp and some really messed up looking coral. Crimson Forests could have crimson variants of the kelp/seagrass, and maybe even a hostile fish like a shark of some sort (which could drops scales/teeth to craft armor which gives a better movement bonus in lava/increased damage in lava), and Nether Wastes could contain blackstone shipwrecks with Bastion loot in them. And of course, any more kinds of corals/plant life would go a long way as the nether is naturally super empty

Overall this is a very promising mod and I appreciate the work and creativity that went into it. I did notice that 3.0.1-1.20 has two Forge releases on the same day but no Fabric release, I hope Fabric is still a possibility for you!

Scouter456 commented 1 year ago

Hello, thanks for all the suggestions, I do appreciate it. I can add some configs for the fish spawning. The features however can be changed with their corresponding file under worldgen -> configured_feature or worldgen -> placed_feature. placed_feature being the one that can be used to change how much it will spawn in the world.

The issue with the blazefish has plagued me for a while, since I can't get them to spawn that good, I have seen them spawn but not a whole lot. I will take a look into it for the next update.

Lava sponges are a feature, so they cant be located, however they are pretty rare. I could probably up the rate at which they spawn.

The issue with the soul sucker boots having a high defense (not intended) was fixed in the 3.0.1 update for fabric (I accidentally tagged it with forge).

The idea for the fish being stunned for a bit is a good one and I will implement this for the next update. Right now they can also be turned in to items with the config file.

I shall take your ideas for the fish in consideration, for the next update as they are pretty decent ideas. The magma cube fish however, can already be fed to frogs. The fortress grouper plate and the eyeball are used to craft lava glass. which allows you to see in the lava.

The nether salad foods is a tag added for compatibility with farmers delig, however since it wasn't updated yet it is unused.

The ideas for the difference under the biomes are also good and I will take a look at implementing some and perhaps some other ideas.

The two releases for 3.0.1 were one for forge and one for fabric. I seem to have put the fabric one with a forge tag.

Ultimushadow commented 1 year ago

Hey thanks for reading through the suggestions! I had kind of figured that 3.0.1 might be tagged wrong but wasn't sure.

I didn't know magma fish could be fed to frogs already! That's a great use for them. The fortress grouper and eyeball fish suggestions were made because while the entities can be killed to drop the items used for lava glass, the fish items you get from them are basically without use. I figured turning them into something that can be used would be most effective at bringing some interest, but another route I could see is doing something similar to the soul suckers. Use the nether grouper item, craft it into plates, use the eyeball fish item, craft it into eyes, and then remove those drops from the entities. I may end up doing that as a datapack for now just so I don't feel bad throwing items away lol Lava glass, by the way, is SUCH a cool block, I absolutely love the concept.

The tag makes more sense with that in mind, I figured it might have been added for other mods, but why not add in some of your own items? Your art is good, and it would help the mod feel like a more complete package that can integrate with food mods, rather than relying on them to add those items.

Again, thanks for reading through everything, I know that was quite the list, I haven't seen a mod with this kind of idea but it just makes so much sense and I will definitely be watching to see where it goes!

Scouter456 commented 1 year ago

I do like the suggestions and have added a lot of them ^^ If you got some more do write ^^ You can also send me a dm on discord

Ultimushadow commented 1 year ago

I wrote a lot of those suggestions basing on the content that was already in the mod, but I didn't really touch on anything added since that list was long enough lol, I can share a few though!

One of the things I think the mod could use is variety, not in the amount of fish but in the types of fish (cuz you already did a great job in the amount of fish!). I think to start, a general guide could be to add one new type of fish to every biome in the nether, for instance:

Some other things I was thinking of was maybe an entirely new biome, so to extend on one of the suggestions I already made, the nether reefs!

Scouter456 commented 1 year ago

Thanks for the suggestions, I will take a look at them and might consider some of them. Some things like the sand for the ocean floors is not really that doable since that would mean overwriting the nether json files, which I can do, but if someone also does it, its just a matter of which one gets chosen so I want to avoid stuff like that unless there is a good way to do it. As for the swimming in lava, there is the hell strider enchant the mod adds that could help with this.

Ultimushadow commented 1 year ago

In that case maybe the sand is best suited for biomes you add yourself then! And oops, I hadn't checked the mod in a bit and forgot you already also add that enchant, my bad šŸ˜… I had been looking through other mods and seen that it was also a standalone, so that's what popped in my mind first

Scouter456 commented 1 year ago

The latest update adds some of your suggestions ^^ aswell as some fixes.

Ultimushadow commented 1 year ago

Great update! Adding the crimson variant of the plants and making sure all the fish have functioning uses adds a good amount of polish. In my pack, I use a couple mods that give descriptions for things like enchantments and potions, I see that you've included a description for Hell Strider which is great! I was thinking, although "Lava Vision" is obviously pretty self explanatory, it may help to give a description just for the sake of polish as well. Something like "Allows the affected to see clearly while under the surface of lava"

I also noticed the Eyeball fish entity doesn't have a translation, there's a minor typo in the advancement for crafting a lava fishing rod, says yourney rather than journey

I see a bunch of translations for food items, those look like a lot of fun and could be in the base mod! Rather than adding the items, the compat could switch the recipes over once Farmer's Delight is loaded. I was trying hard not to add Farmer's Delight to my pack but if you think the foods belong compat only I might have to reconsider... šŸ˜…

Also, with the glowing potion, I was wondering if you could rename some things. It actually is due to the arrows you can craft with the potions being functionally identical to Spectral arrows. I think you could potentially rename the potions to "Spectral Potions", and change the recipe to be more similar to the vanilla Spectral arrows. Rather than use 8 arrows, they should use 4 and give 8 to keep in line with how normal Spectral arrows double the base arrow in the recipe (that, or you could have 8 arrows craft into 16). Then, since they're basically the same, have the base glowing potion craft vanilla Spectral arrows, and have the stronger glowing potion craft "Enhanced Spectral Arrows" - you could add this as a new item or just retexture and rename the potion arrows that are already there. Let me know what you think!

Scouter456 commented 11 months ago

I have fixed the typos and added the eyeball fish translation