search

ScratMan / HASmartThermostat

Smart Thermostat with PID controller for HomeAssistant
338 stars 49 forks source link

Responsiveness is slow #75

Open csmit86 opened 2 years ago

csmit86 commented 2 years ago

When I change the preferred temp it always takes a while to turn off or on. I noticed it's exactly 5 min, which is what I have set in the sampling period parameter. Is this a bug or expected behavior?

I remember it use to respond directly to user input.

ScratMan commented 2 years ago

If you set the sampling period, the PID will reject new commands until the period is ended to accept a new sample. So yes, normal behaviour. I'll try to add a bypass of this period when target temp is changed.

dorinvlas commented 1 year ago

If you set the sampling period, the PID will reject new commands until the period is ended to accept a new sample. So yes, normal behaviour. I'll try to add a bypass of this period when target temp is changed.

Hi Adrien. Did you had the opportunity to implement that bypass? If yes in what version?

Thanks for making us more energy efficient ;)

T81 commented 1 year ago

If you set the sampling period, the PID will reject new commands until the period is ended to accept a new sample. So yes, normal behaviour. I'll try to add a bypass of this period when target temp is changed.

This would be great and it is needed. Also adding a small delay of 2-4 seconds before calculating again would be nice, since user's input needs debouncing. ;)

T81 commented 1 year ago

If you set the sampling period, the PID will reject new commands until the period is ended to accept a new sample. So yes, normal behaviour. I'll try to add a bypass of this period when target temp is changed.

I had the same issue but it wasn't the sampling period but the keep alive setting. Setting it to 1 second fixed this (and a lot of other issues) and I would recommend this setting, even being the default. What do you think?