search

Scratch-Bookmarklets / Scratch-Bookmarklets.github.io

The site of @Scratch-Bookmarklets.
https://scratch-bookmarklets.github.io
BSD 3-Clause "New" or "Revised" License
6 stars 10 forks source link

Patch 5: Updates Website #127

Closed xItzDiamondx closed 3 years ago

xItzDiamondx commented 3 years ago

Resolves

Resolves none

Changes

I made the website a bit better Reason for changes

Tests I have tested on my fork

Extra Context If going to merge, please squash and merge,

FunctionalMetatable commented 3 years ago

please make new branches for pr'ing. the commit history is very long

gosoccerboy5 commented 3 years ago

please make new branches for pr'ing. the commit history is very long

Agreed. In addition, develop locally with Github Desktop if possible, and make sure to squash and merge when merging PR with many commits

xItzDiamondx commented 3 years ago

I had GHD but I deleted it because my PC was running too slowly. I do use VS Code and test locally though.

On Tue, May 25, 2021 at 7:41 PM gosoccerboy5 @.***> wrote:

please make new branches for pr'ing. the commit history is very long

Agreed. In addition, develop locally with Github Desktop <//desktop.github.com> if possible, and make sure to squash and merge when merging PR with many commits

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Scratch-Bookmarklets/Scratch-Bookmarklets.github.io/pull/127#issuecomment-848373875, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATNX7MF7KQH5M4PAIFKUNCDTPQ7S5ANCNFSM45QFBZHA .

Shluffy commented 3 years ago

otherwise, everything looks good.

Shluffy commented 3 years ago

This only solves the problem on the contributors page, not on all of them.

Shluffy commented 3 years ago

the purpose of this pr has already been fixed.

xItzDiamondx commented 3 years ago

it has a few more patches so ima merge

On Wed, May 26, 2021 at 3:11 PM ShluffyMonster @.***> wrote:

Closed #127 https://github.com/Scratch-Bookmarklets/Scratch-Bookmarklets.github.io/pull/127 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Scratch-Bookmarklets/Scratch-Bookmarklets.github.io/pull/127#event-4801719889, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATNX7MEUGR2ELM444G2PFJDTPVIVJANCNFSM45QFBZHA .