Scratch-Client-4 / client

🖥 The SC4 desktop client. Devlopement currently halted while we work on our mobile client : https://github.com/Scratch-Client-4/mobile
GNU General Public License v3.0
11 stars 1 forks source link

Add a favicon. #20

Open forevertoofr opened 4 years ago

forevertoofr commented 4 years ago

The website have no one favicon. Maybe add one ? I will try to code it. I know who then.

ghost commented 4 years ago

You can make a favicon pretty easily. I think it works with GitHub pages by just making a file called favicon.ico

forevertoofr commented 4 years ago

Yeah but you can add a thing in the code if not GitHub pages.

retronbv commented 4 years ago

the website is deployed with firebase (i think) so just make a pull request with a favicon and the code in index.html

locness3 commented 4 years ago

In fact, favicon.ico alone works, no matter github pages or not, bc browsers will automatically try to get /favicon.ico (and that's how you have favicons when viewing non-html stuff like an image). Although you should include it in code.

forevertoofr commented 4 years ago

If i add the favicon on a other website (mine) cause i don't know how to add images + edit a file in a pull request can i ?

locness3 commented 4 years ago

To add an image to a Git repository, clone it to your computer, add the file to the folder, stage and commit. If you want to do it through GitHub's web interface, just drag it and drop it onto your repository's page (but do it on a branch!) tho I highly recommend you to use GitHub Desktop, it makes it way easier to use git.

forevertoofr commented 4 years ago

Yeah on my old pc i used it. Thanks for the tip @locness3 !

micahlt commented 4 years ago

@locness3 I seriously prefer the git CLI to the desktop version. Idk why, I'm weird xD

On Sun, May 10, 2020, 1:11 AM Locness notifications@github.com wrote:

To add an image to a Git repository, clone it to your computer, add the file to the folder, stage and commit. If you want to do it through GitHub's web interface, just drag it and drop it onto your repository's page (but do it on a branch!) tho I highly recommend you to use GitHub Desktop, it makes it way easier to use git.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Scratch-Client-4/client/issues/20#issuecomment-626279435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG33HKMBW47MIKUXDZN2EXDRQZARFANCNFSM4M4XBSEQ .

locness3 commented 4 years ago

Some workflows are way eaiser with github desktop (which btw hasn't anything to do with git itself), like modifying someone else's PR.

grngxd commented 4 years ago

@locness3 I seriously prefer the git CLI to the desktop version. Idk why, I'm weird xD … On Sun, May 10, 2020, 1:11 AM Locness @.***> wrote: To add an image to a Git repository, clone it to your computer, add the file to the folder, stage and commit. If you want to do it through GitHub's web interface, just drag it and drop it onto your repository's page (but do it on a branch!) tho I highly recommend you to use GitHub Desktop, it makes it way easier to use git. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG33HKMBW47MIKUXDZN2EXDRQZARFANCNFSM4M4XBSEQ .

same lol

ghost commented 4 years ago

Try adding the image to the repo then update every .html file I think

micahlt commented 4 years ago

@hhbo62 We know how to add one, but work on this project is suspended.

ghost commented 4 years ago

Oh why was it suspended?

locness3 commented 4 years ago

We're working on our mobile client, https://github.com/Scratch-Client-4/mobile

ghost commented 4 years ago

‘K, get it